[wp-trac] [WordPress Trac] #30767: Non-repo plugins with updates available not listed on updates screen

[WordPress Trac]

#30767: Non-repo plugins with updates available not listed on updates screen
-------------------------------------+--------------------
 Reporter:  lumpysimon               |       Owner:
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  4.1.1
Component:  Upgrade/Install          |     Version:  4.1
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:
-------------------------------------+--------------------

Comment (by valendesigns):

 I'm definitely leaning towards the first patch over the second one,
 especially after testing a bit more last night. Since there are checks for
 `isset` all over the `list_plugin_updates` function we are pretty safe in
 letting it move forward when it's not a WP repo plugin. Obviously we can't
 know all the different ways people implement non-repo updates but at least
 we're not stopping them from showing anymore. The issue with checking if
 the response is external is that we're assuming they are filtering on the
 plugin slug and the plugin is still activated. It could very well have
 been deactivated recently but the update info is still saved in the
 database. In that situation `update-core.php` would think there is an
 update but `list_plugin_updates` would fail to produce the correct
 information when we run `plugins_api`. Not a huge issue, but does mean
 there will be an empty table until the cashed update info is rebuilt.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30767#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform