[wp-trac] [WordPress Trac] #30767: Non-repo plugins with updates available not listed on updates screen

WordPress Trac noreply at wordpress.org
Fri Jan 23 07:19:12 UTC 2015


#30767: Non-repo plugins with updates available not listed on updates screen
-------------------------------------+--------------------
 Reporter:  lumpysimon               |       Owner:
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  4.1.1
Component:  Upgrade/Install          |     Version:  4.1
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:
-------------------------------------+--------------------
Changes (by valendesigns):

 * keywords:  needs-patch => has-patch needs-testing


Comment:

 This is actually a simple fix if I'm correctly understanding what's
 happening in `update-core.php`. We just need to check that the package URL
 is for a WordPress Directory plugin or the UI doesn't load because of a
 `continue` when `plugins_api` returns a WP error. In some implementations
 like the Github Updater, the slug being filtered is actually different
 than `$plugin_data->update->slug`. It also includes the plugin file name.
 So the response doesn't get filtered and the code is allowed to run
 thinking it's a WP directory plugin, even though it's not.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30767#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list