[wp-trac] [WordPress Trac] #30945: WP_Upgrader: Incorrect plugin folder after updating from remote (non-WP) URL

[WordPress Trac]

#30945: WP_Upgrader: Incorrect plugin folder after updating from remote (non-WP)
URL
--------------------------+-----------------------------
 Reporter:  miyarakira    |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Future Release
Component:  Plugins       |     Version:  4.1
 Severity:  normal        |  Resolution:
 Keywords:                |     Focuses:
--------------------------+-----------------------------
Changes (by danielbachhuber):

 * keywords:  reporter-feedback =>
 * milestone:  Awaiting Review => Future Release


Comment:

 Reported to WP-CLI too: https://github.com/wp-cli/wp-cli/issues/1619

 Aside from the conversation about folder structures, I think
 `wp_tempnam()` shouldn't clobber extensions associated with archive
 formats and / or `WP_Upgrader::run()` should know to clean up `.tmp` from
 the directory name. The latter is likely a more minor decision.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30945#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform