[wp-trac] [WordPress Trac] #30988: Setting's default value doesn't apply on preview window

WordPress Trac noreply at wordpress.org
Tue Jan 20 20:24:03 UTC 2015


#30988: Setting's default value doesn't apply on preview window
-------------------------------------------------+-------------------------
 Reporter:  Aniruddh                             |       Owner:  ocean90
     Type:  defect (bug)                         |      Status:  reviewing
 Priority:  normal                               |   Milestone:  4.1.1
Component:  Customize                            |     Version:  4.1
 Severity:  normal                               |  Resolution:
 Keywords:  needs-testing reporter-feedback      |     Focuses:
  has-patch                                      |  administration
-------------------------------------------------+-------------------------

Comment (by ocean90):

 [attachment:30988.2.diff]:
 * Tests: It's not clear enough which test is specific for this issue. Also
 there are to many assertions in one tests. These should be splitted up.
 Closures should be removed too.
 * `parse_post_data()`: Can't we introduce  `private function
 post_values()` and use `$this->post_values();` instead of
 `$this->parse_post_data(); `$this->_post_values;`?
 * I'm missing a test case to verify the issue.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30988#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list