[wp-trac] [WordPress Trac] #30799: Scrutinizer in 4.2

[WordPress Trac]

#30799: Scrutinizer in 4.2
----------------------------+--------------------
 Reporter:  wonderboymusic  |       Owner:
     Type:  defect (bug)    |      Status:  new
 Priority:  normal          |   Milestone:  4.2
Component:  General         |     Version:  trunk
 Severity:  normal          |  Resolution:
 Keywords:                  |     Focuses:
----------------------------+--------------------

Comment (by wonderboymusic):

 In [changeset:"31220"]:
 {{{
 #!CommitTicketReference repository="" revision="31220"
 Fix some internal types that are passed to functions to avoid changing the
 acceptable types passed as arguments to those functions:

 * In `WP_Importer->is_user_over_quota()`, the default value for the first
 argument for `upload_is_user_over_quota()` is `true`. Don't bother passing
 `1`.
 * When calling `submit_button()` with no `$name`, pass empty string
 instead of `false`.
 * The default value for the 2nd argument to `get_edit_post_link()` is
 `'display'`. Because PHP is PHP, passing `true` is the same as passing
 `'display'` or nothing. Don't bother passing `true`.
 * In `WP_User_Meta_Session_Tokens::drop_sessions()`, pass `0` instead of
 `false` to `delete_metadata()` as the value for `$object_id`, which
 expects an int.

 See #30799.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30799#comment:51>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform