[wp-trac] [WordPress Trac] #31033: Organize the Custom Background function

[WordPress Trac]

#31033: Organize the Custom Background function
---------------------------+-----------------------------
 Reporter:  Shaped Pixels  |      Owner:
     Type:  defect (bug)   |     Status:  new
 Priority:  normal         |  Milestone:  Awaiting Review
Component:  Customize      |    Version:  4.1
 Severity:  normal         |   Keywords:
  Focuses:                 |
---------------------------+-----------------------------
 Two items here:

 (1) I've noticed that the Background admin link under Appearance, now
 loads up in the Customizer. This is fine, but what I noticed (and a couple
 others have agreed with me in chat), that the "Background Image" tab
 creates confusion when the background colour is loaded separately in the
 "Colours" tab. Also, in the Background Image tab, you get two identical
 labels of "Background Image". I would like to recommend this get changed
 so that the Background Image tab is simply renamed as "Background" or
 "Page Background" which might be more relevant. Then, move the background
 colour setting into that location because it relates directly with the
 custom background function. Many people will do variations like a
 background colour only, a background colour with a transparent image, or
 just an image, but the colour should always exist with or without the
 image.

 When I make themes, I've been de-registering both and then redoing a Page
 Background tab in the customizer.

 (2) The second problem I've noticed, is that the "colour" when I select
 one, plus the default colour is not applied to the CSS. Right now for a
 theme I am creating, on the latest WordPress, I get this generated style:


 {{{
 <style type="text/css" id="custom-background-css">
 body.custom-background { background-image:
 url('http://localhost/shapedpixels/wp-
 content/themes/shapedpixelspro/images/scanlines.png'); background-repeat:
 repeat; background-position: top left; background-attachment: fixed; }
 </style>
 }}}


 The background colour I have set is not shown here, so I have to do an
 override from the theme's style.css level. Was this purposely taken out or
 is this a bug that the system is not loading the background colour with
 the image? Incidentally, this should not be loaded as "background-image:"
 but as "background:". I'm going to assume this is a possible bug?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31033>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform