[wp-trac] [WordPress Trac] #30997: Update grunt-cssjanus to fix RTL CSS Issues

WordPress Trac noreply at wordpress.org
Tue Jan 13 05:39:32 UTC 2015


#30997: Update grunt-cssjanus to fix RTL CSS Issues
------------------------------+-------------------------
 Reporter:  netweb            |      Owner:
     Type:  defect (bug)      |     Status:  new
 Priority:  normal            |  Milestone:  4.2
Component:  Build/Test Tools  |    Version:  4.0
 Severity:  normal            |   Keywords:  needs-patch
  Focuses:                    |
------------------------------+-------------------------
 Currently we are using a patched fork of CSSJanus via r29282 / #29038

 The patched fork being used is
 https://github.com/cssjanus/cssjanus/pull/20

 Updating to CSSJanus v1.1.1 fixes numerous issues in the following files:

 {{{
 wp-admin/css/common-rtl.css
 wp-admin/css/customize-controls-rtl.css
 wp-admin/css/customize-controls-rtl.min.css
 wp-admin/css/customize-widgets-rtl.css
 wp-admin/css/customize-widgets-rtl.min.css
 wp-admin/css/list-tables-rtl.css
 wp-admin/css/media-rtl.css
 wp-admin/css/themes-rtl.css
 wp-admin/css/wp-admin-rtl.min.css
 wp-includes/css/buttons-rtl.css
 wp-includes/css/buttons-rtl.min.css
 wp-includes/css/editor-rtl.css
 wp-includes/css/editor-rtl.min.css
 wp-includes/css/jquery-ui-dialog-rtl.css
 wp-includes/css/jquery-ui-dialog-rtl.min.css
 wp-includes/css/media-views-rtl.css
 wp-includes/css/media-views-rtl.min.css
 }}}

 @Oceans90, a couple of options, ideally the first option is preferred, if
 not the second:

 1. Update your pull request at
 https://github.com/cssjanus/cssjanus/pull/20 so it merges cleanly and we
 can natively revert to `grunt-cssjanus` once that pull request is merged
 and with hopefully a pending CSSJanus dependancy update from coming from
 @yoavf in https://github.com/yoavf/grunt-cssjanus/issues/4

 2. Update both your forks https://github.com/ocean90/grunt-cssjanus and
 https://github.com/ocean90/cssjanus to use CSSJanus v1.1.1 as the primary
 dependancy for `grunt-cssjanus`

 Attached for '''reference only''' even though the `border-radius` bug is
 included are the extra changes to the RTL `/build` files using CSSJanus
 v1.1.1.

 Please and thank you in advance :)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30997>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list