[wp-trac] [WordPress Trac] #30566: Fix "Trying to get property of non-object" notice when calling get_blogaddress_by_id() with an invalid id.

[WordPress Trac]

#30566: Fix "Trying to get property of non-object" notice when calling
get_blogaddress_by_id() with an invalid id.
--------------------------------+-------------------------
 Reporter:  nerrad              |       Owner:  jeremyfelt
     Type:  defect (bug)        |      Status:  reopened
 Priority:  normal              |   Milestone:  4.2
Component:  Networks and Sites  |     Version:  3.0
 Severity:  normal              |  Resolution:
 Keywords:  has-patch           |     Focuses:  multisite
--------------------------------+-------------------------

Comment (by SergeyBiryukov):

 Replying to [comment:19 nerrad]:
 > I was going to just check for a truthy value, but get_blog_details()
 also has a late filter run on it.  So its *possible* a plugin might return
 a non truthy value.

 Yeah, but returning anything other than a blog object would cause an issue
 in `get_blog_details()` itself when [source:tags/4.1/src/wp-includes/ms-
 blogs.php#L216 calculating the cache key]. So that would be a developer
 error that would result in a notice anyway.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30566#comment:20>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform