[wp-trac] [WordPress Trac] #30566: Fix "Trying to get property of non-object" notice when calling get_blogaddress_by_id() with an invalid id.

WordPress Trac noreply at wordpress.org
Mon Jan 12 13:41:04 UTC 2015


#30566: Fix "Trying to get property of non-object" notice when calling
get_blogaddress_by_id() with an invalid id.
--------------------------------+-------------------------
 Reporter:  nerrad              |       Owner:  jeremyfelt
     Type:  defect (bug)        |      Status:  reopened
 Priority:  normal              |   Milestone:  4.2
Component:  Networks and Sites  |     Version:  3.0
 Severity:  normal              |  Resolution:
 Keywords:  has-patch           |     Focuses:  multisite
--------------------------------+-------------------------
Changes (by SergeyBiryukov):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 Looks like `get_blog_details()` returns false on failure.

 Could we just check for a truthy value and remove the `isset()` checks?
 See [attachment:30566.patch].

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30566#comment:18>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list