[wp-trac] [WordPress Trac] #30891: Unchecked property overloading is detrimental to OOP.

WordPress Trac noreply at wordpress.org
Sat Jan 10 23:43:44 UTC 2015


#30891: Unchecked property overloading is detrimental to OOP.
--------------------------+------------------
 Reporter:  aercolino     |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  4.2
Component:  General       |     Version:  4.0
 Severity:  normal        |  Resolution:
 Keywords:                |     Focuses:
--------------------------+------------------

Comment (by wonderboymusic):

 In [changeset:"31137"]:
 {{{
 #!CommitTicketReference repository="" revision="31137"
 In `Walker`:

 * Every subclass of `Walker` overrides `$db_fields` and makes it public
 * `wp_list_comments()` accesses `->max_pages` on an instance of `Walker`,
 it must be public
 * `$has_children` was added as `protected` in 4.0. doesn't need BC

 Make `$db_fields` and `$max_pages` public and remove magic methods.

 See #30891.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30891#comment:16>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list