[wp-trac] [WordPress Trac] #30891: Unchecked property overloading is detrimental to OOP.

[WordPress Trac]

#30891: Unchecked property overloading is detrimental to OOP.
--------------------------+------------------
 Reporter:  aercolino     |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  4.2
Component:  General       |     Version:  4.0
 Severity:  normal        |  Resolution:
 Keywords:                |     Focuses:
--------------------------+------------------

Comment (by jdgrimes):

 Replying to [comment:12 wonderboymusic]:
 > I made them `private` in [28481], that was unnecessary... and every bit
 of this class was public previously. Do you have a use case for these
 classes outside of `_custom_header_background_just_in_time()`?

 No, I don't have a use case. I just wanted to clarify that I don't think
 they have to be made public. If the goal is to remove the magic methods
 where they aren't absolutely needed, then this makes sense.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30891#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform