[wp-trac] [WordPress Trac] #30501: Prevent flushing rewrites during page load

[WordPress Trac]

#30501: Prevent flushing rewrites during page load
-------------------------------------------------+-------------------------
 Reporter:  joostdevalk                          |       Owner:
     Type:  defect (bug)                         |  SergeyBiryukov
 Priority:  normal                               |      Status:  accepted
Component:  Permalinks                           |   Milestone:  4.2
 Severity:  normal                               |     Version:
 Keywords:  has-patch dev-feedback 4.2-early     |  Resolution:
  commit                                         |     Focuses:
-------------------------------------------------+-------------------------

Comment (by Funkatronic):

 Replying to [comment:20 joostdevalk]:
 > Flushing on every page load is still bad and this patch does not prevent
 that. What this DOES prevent is a plugin or theme running
 flush_rewrite_rules before plugins have had a chance to register their
 rewrites, which causes URLs to break. So it doesn't prevent it from
 running, it just moves it.

 Is `add_action` smart enough to call `flush_rewrite_rules` only once vs
 the n amount of calls various plugins will do?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30501#comment:21>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform