[wp-trac] [WordPress Trac] #30799: Scrutinizer in 4.2

[WordPress Trac]

#30799: Scrutinizer in 4.2
----------------------------+--------------------
 Reporter:  wonderboymusic  |       Owner:
     Type:  defect (bug)    |      Status:  new
 Priority:  normal          |   Milestone:  4.2
Component:  General         |     Version:  trunk
 Severity:  normal          |  Resolution:
 Keywords:                  |     Focuses:
----------------------------+--------------------

Comment (by wonderboymusic):

 In [changeset:"31116"]:
 {{{
 #!CommitTicketReference repository="" revision="31116"
 In `Custom_Background` and `Custom_Header`:

 * In `->init()`, don't check `current_user_can()` since `add_theme_page()`
 will return `false` immediately if the cap check fails.
 * Bail if `add_theme_page()` returns `false`
 * `wp_check_filetype_and_ext()` doesn't need a 3rd param, it already
 defaults to `null`. Passing `false` would fail a strict check.

 See #30799.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30799#comment:25>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform