[wp-trac] [WordPress Trac] #30958: admin.php should properly set "now" globals

[WordPress Trac]

#30958: admin.php should properly set "now" globals
----------------------------+-----------------------------
 Reporter:  wonderboymusic  |       Owner:  wonderboymusic
     Type:  defect (bug)    |      Status:  reopened
 Priority:  normal          |   Milestone:  4.2
Component:  Administration  |     Version:
 Severity:  normal          |  Resolution:
 Keywords:                  |     Focuses:
----------------------------+-----------------------------
Changes (by nacin):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 While in practice it probably doesn't matter here, there *is* a difference
 between `isset( $a )` and `if ( $a )`.

 However, this seems like it would break any other check (such as in a
 plugin) of `isset( $hook_suffix )` or `isset( $plugin_page )` etc,
 especially since core was doing it (in API functions, not just where they
 were maybe declared).

 I'd argue that the best approach here would be to specify them as `global`
 but keep the initialization as is.

 While it's possible — even probable — we break this later down the line,
 there's no need to do so now. Thoughts?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30958#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform