[wp-trac] [WordPress Trac] #30168: Collapse additional avatar settings if avatars are disabled

WordPress Trac noreply at wordpress.org
Thu Jan 8 16:33:51 UTC 2015


#30168: Collapse additional avatar settings if avatars are disabled
-------------------------+---------------------------------
 Reporter:  markjaquith  |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  4.2
Component:  Comments     |     Version:
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |     Focuses:  ui, administration
-------------------------+---------------------------------

Comment (by helen):

 Replying to [comment:10 valendesigns]:
 > In order to make those show up we would need to remove the first 2 lines
 from `get_avatar`.

 We can use `pre_option_show_avatars` to force it for just this instance,
 see [attachment:30168.7.diff].

 Using an existing class allows us to set it on the server side so there's
 no jumping on load. I used hide-if-js instead, so that in the case of no-
 JS (broken JS or user choice), they don't have to set the option and save
 in order to show the rest of the settings.

 Committing shortly.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30168#comment:15>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list