[wp-trac] [WordPress Trac] #30799: Scrutinizer in 4.2

[WordPress Trac]

#30799: Scrutinizer in 4.2
----------------------------+--------------------
 Reporter:  wonderboymusic  |       Owner:
     Type:  defect (bug)    |      Status:  new
 Priority:  normal          |   Milestone:  4.2
Component:  General         |     Version:  trunk
 Severity:  normal          |  Resolution:
 Keywords:                  |     Focuses:
----------------------------+--------------------

Comment (by wonderboymusic):

 In [changeset:"31078"]:
 {{{
 #!CommitTicketReference repository="" revision="31078"
 Access Modifiers:

 * In `WP_Plugin_Install_List_Table`, use `public` instead of `var`
 * In `WP_User`, `->data` is accessed directly on an instance if the
 constructor receives it: make it `public`
 * In `WP_Locale`, every property is exported to a global and is already
 `public` via `var`, half of the properties are accessed directly already,
 make them all `public`
 * In `WP_Rewrite`, several properties are accessed publicly in functions
 via the `$wp_rewrite` global, make those props `public`.
 * In `WP_Rewrite`, the property `->comment_feed_structure` was misspelled
 as `->comments_feed_structure`

 See #30799.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30799#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform