[wp-trac] [WordPress Trac] #30945: WP_Upgrader: Incorrect plugin folder after updating from remote (non-WP) URL

[WordPress Trac]

#30945: WP_Upgrader: Incorrect plugin folder after updating from remote (non-WP)
URL
-------------------------------+------------------------------
 Reporter:  miyarakira         |       Owner:
     Type:  defect (bug)       |      Status:  new
 Priority:  normal             |   Milestone:  Awaiting Review
Component:  Plugins            |     Version:  4.1
 Severity:  normal             |  Resolution:
 Keywords:  reporter-feedback  |     Focuses:
-------------------------------+------------------------------

Comment (by dd32):

 Replying to [comment:2 miyarakira]:
 > It installs fine via Plugins -> Add New -> Upload. If you change the
 plugin version to, say, 0.0.1 and perform an update, that's when the
 folder name changes.

 Yep, it doesn't match the zip format WordPress expects for updates.
 Currently it's like this:
 {{{
 plugin.zip
 + plugin.php
 + readme.txt
 }}}
 where it needs to be like:
 {{{
 plugin.zip
 + plugin/
   - plugin.php
   - readme.txt
 }}}

 We can do better and fix the case where it ends up as `plugin.tmp` quite
 easily, but then the other case of `actiondownloadslugmy-plugin` isn't
 fixable, unless you add the extra directory to the zip file.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30945#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform