[wp-trac] [WordPress Trac] #30770: Twenty Fifteen: Theme Review: Stylesheets and Scripts

WordPress Trac noreply at wordpress.org
Tue Jan 6 03:13:33 UTC 2015


#30770: Twenty Fifteen: Theme Review: Stylesheets and Scripts
---------------------------+-----------------------
 Reporter:  emiluzelac     |       Owner:
     Type:  defect (bug)   |      Status:  reopened
 Priority:  normal         |   Milestone:  4.2
Component:  Bundled Theme  |     Version:  4.1
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |     Focuses:
---------------------------+-----------------------

Comment (by valendesigns):

 Replying to [comment:40 peterwilsoncc]:
 > My aim is to protect against two things:
 > * child themers adding a class to the HTML element directly into a
 header.php override.
 > * child themers doing_it_wrong by hard coding modernizr or similar into
 a header.php override.

 If we're trying to fix those use cases in this ticket, I think the
 JavaScript should be changed to the code below. I've added a new patch.

 {{{
 document.documentElement.className =
 document.documentElement.className.replace('no-js','js')
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30770#comment:41>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list