[wp-trac] [WordPress Trac] #30770: Twenty Fifteen: Theme Review: Stylesheets and Scripts

WordPress Trac noreply at wordpress.org
Tue Jan 6 02:08:07 UTC 2015

#30770: Twenty Fifteen: Theme Review: Stylesheets and Scripts
 Reporter:  emiluzelac     |       Owner:
     Type:  defect (bug)   |      Status:  reopened
 Priority:  normal         |   Milestone:  4.2
Component:  Bundled Theme  |     Version:  4.1
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |     Focuses:

Comment (by valendesigns):

 Replying to [comment:38 peterwilsoncc]:
 > Replying to [comment:37 iamtakashi]:
 > > We do need to replace `no-js` class with the current CSS:
 > Uploaded 30770.2.diff with a modified version of the Paul Irish

 Thank you for adding an updated patch. However, I think
 [attachment:30770.diff] is still the correct course of action here. The
 code is being loaded before all other scripts and in the case of child
 themes or modernizr they would still be able to add classes to the `html`
 element by overriding the modification in a separate script, since they
 are called after `wp_head` via the `wp_enqueue_scripts` action. Please
 correct me if I'm wrong, but I don't see a reason to change the JavaScript
 to make it any more compatible. The issue here (IMO) is how this
 particular piece of code is being loaded into `header.php` and not how it
 changes `no-js` to `js` in the `html` element.

Ticket URL: <https://core.trac.wordpress.org/ticket/30770#comment:39>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform

More information about the wp-trac mailing list