[wp-trac] [WordPress Trac] #16024: Conditional Comments for JS
WordPress Trac
noreply at wordpress.org
Tue Jan 6 01:35:14 UTC 2015
#16024: Conditional Comments for JS
--------------------------------------------------+-----------------------
Reporter: filosofo | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: 4.2
Component: Script Loader | Version: 3.1
Severity: normal | Resolution:
Keywords: has-patch needs-testing dev-feedback | Focuses: template
--------------------------------------------------+-----------------------
Comment (by valendesigns):
Replying to [comment:90 azaozz]:
> In 16024.9.diff: cleaned up the latest patch and added support for the
(newly committed) `data-after`. Still unsure if we really need to be able
to output some script data in an arbitrary place after the script tag
(seems not that useful), so holding up on this for few days.
Thank you for cleaning up the patch. However, I removed the code specific
to Twenty Twelve because it's not what this ticket is solving. I created
ticket #30863 to specifically address that code, and it was shot down as a
backwards compatibility issue, which I agree with. I think a new patch
should be created without the theme dependent code in it. Thoughts?
--
Ticket URL: <https://core.trac.wordpress.org/ticket/16024#comment:91>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list