[wp-trac] [WordPress Trac] #30839: 'edit-tags.php' and some others
WordPress Trac
noreply at wordpress.org
Sun Jan 4 10:16:09 UTC 2015
#30839: 'edit-tags.php' and some others
--------------------------+-----------------------------
Reporter: suifengtec | Owner:
Type: defect (bug) | Status: closed
Priority: normal | Milestone:
Component: Taxonomy | Version: 4.1
Severity: normal | Resolution: maybelater
Keywords: | Focuses: administration
--------------------------+-----------------------------
Comment (by suifengtec):
Replying to [comment:3 boonebgorges]:
> Hi suifengtec - Welcome to Trac, and thanks for the suggestions.
>
> > the current admin screen edit-tags.php is also used to edit the
categories,so I think the file for terms edit screen should be named edit-
terms.php.
>
> If we were building WordPress from scratch today, we'd probably go with
something like edit-terms.php. But it's not something we can easily change
at this point. For one thing, many plugins etc link directly to URLs built
using the filename 'edit-tags.php', links that would break if we simply
changed the name of the file.
>
> > The action hook quick_edit_custom_box should can be used to extend
quick editing for terms(such as category/tag logo or sothing else),but it
does not support it now( without a term row parameter ).so I think we
should add an parameter( $tag->term_id ) to it.
>
> 'quick_edit_custom_box' appears in the
`WP_Terms_List_Table::inline_edit()` method. This method builds a single
`<form>` element for the entire list table, which is then moved around the
screen and populated with term-specific values using JS. In other words,
when the markup is built and the hook fires, there's no way of knowing
which specific term it'll be used for - and in fact, it could be used for
*any* term on the page. So, if you want to add term-specific fields to
Quick Edit, you'll have to use JavaScript to populate the fields. See wp-
admin/js/inline-edit-tax.js (especially the `edit()` function) to see how
WP does it.
>
> I'll mark this ticket as 'maybelater' in case we decide at some point in
the future to change the filenames of some wp-admin files.
--------
thanks!
--
Ticket URL: <https://core.trac.wordpress.org/ticket/30839#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list