[wp-trac] [WordPress Trac] #30666: Add a comment to RTL and minified files for new contributors

WordPress Trac noreply at wordpress.org
Fri Jan 2 02:46:28 UTC 2015

#30666: Add a comment to RTL and minified files for new contributors
 Reporter:  SergeyBiryukov              |       Owner:
     Type:  enhancement                 |      Status:  new
 Priority:  normal                      |   Milestone:  Awaiting Review
Component:  Build/Test Tools            |     Version:
 Severity:  normal                      |  Resolution:
 Keywords:  dev-feedback needs-refresh  |     Focuses:  docs
Changes (by netweb):

 * keywords:  has-patch dev-feedback => dev-feedback needs-refresh


 Thanks Derek, as `grunt-contrib-cssmin` is removing banner support I think
 this is the best way forward, I'd not be surprised if `grunt-contrib-
 uglify` followed suit in the not to distant future and also removed banner

 A couple of issues on includes and excludes:
 * `usebanner:cssjanus` looks good
 * `usebanner:cssmin` should only add a banner to the files we minify the
 `/wp-admin` files listed
 [https://core.trac.wordpress.org/browser/trunk/Gruntfile.js#L130 here],
 `/wp-includes` looks good
 * `usebanner:uglify` is adding a banner to `wp-includes/js/zxcvbn.min.js`,
 your excluding the exclusion ;)
 * `usebanner:uglify` should exclude adding banners to TinyMCE JavaScript
 files, then after `concat:tinymce` has run, add a single banner to the
 concatanated build/wp-includes/js/tinymce/wp-tinymce.js` file (Here's what
 it currently looks like https://cloudup.com/cm8rM4N1lae)

Ticket URL: <https://core.trac.wordpress.org/ticket/30666#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform

More information about the wp-trac mailing list