[wp-trac] [WordPress Trac] #17413: Code added by WP_List_Table::_js_vars is duplicated

WordPress Trac noreply at wordpress.org
Thu Jan 1 19:54:55 UTC 2015


#17413: Code added by WP_List_Table::_js_vars is duplicated
----------------------------+-----------------------------
 Reporter:  sorich87        |       Owner:  wonderboymusic
     Type:  defect (bug)    |      Status:  closed
 Priority:  normal          |   Milestone:  4.2
Component:  Administration  |     Version:  3.2
 Severity:  normal          |  Resolution:  fixed
 Keywords:  has-patch       |     Focuses:  administration
----------------------------+-----------------------------
Changes (by wonderboymusic):

 * owner:   => wonderboymusic
 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"31019"]:
 {{{
 #!CommitTicketReference repository="" revision="31019"
 `WP_List_Table`'s constructor registers an `'admin_footer'` callback when
 AJAX is enabled. As such, if you create multiple instances of the class,
 you get multiple JS blobs on the page when the callbacks fire. Extra
 instances get made when `wp_comment_reply()` invokes the class constructor
 without checking for the existing instance via the `$wp_list_table`
 global.

 We shall check the `$wp_list_table` global in `wp_comment_reply()`.

 Props sorich87.
 Fixes #17413.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/17413#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list