[wp-trac] [WordPress Trac] #31373: Revamp Press This

[WordPress Trac]

#31373: Revamp Press This
-----------------------------+-----------------------
 Reporter:  michael-arestad  |       Owner:  azaozz
     Type:  task (blessed)   |      Status:  assigned
 Priority:  normal           |   Milestone:  4.2
Component:  Press This       |     Version:  trunk
 Severity:  normal           |  Resolution:
 Keywords:                   |     Focuses:
-----------------------------+-----------------------

Comment (by azaozz):

 Replying to [comment:28 ocean90]:
 > * Add missing actions for printing styles/scripts.

 Not sure this is a good idea. Many plugins do many things in the admin.
 Actually was thinking we shouldn't fire any of the default admin actions
 but only Press This specific actions.

 > * Since `$hook_suffix` is null, hardcode `press-this.php`.

 `$hook_suffix` is set in `wp-admin/admin.php` loaded from `press-
 this.php`: https://core.trac.wordpress.org/browser/trunk/src/wp-admin
 /press-this.php#L12

 If it is not set in some circumstances, we still need to set it globally
 as many plugins use it to determine when to output scripts/styles.

 > * Restore body classes, add filter.

 Again, not sure that is "wise", at least not for all the body classes :)
 For example currently Press This doesn't support admin colors (the PT css
 is completely separate from the rest of wp-admin.css). Having a color
 class may trigger something we don't want. If a plugin adds something that
 triggers on a particular body class, and expects wp-admin.css to me
 loaded, it will fail and might affect Press This.

 Was thinking we could/should move the HTML generation inside press-
 this.php, so it is inline with the rest of the admin "entry points" (the
 way it used to be). That means it will run directly in global scope, like
 the rest of wp-admin.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31373#comment:30>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform