[wp-trac] [WordPress Trac] #26600: Search installed themes input has no submit button

[WordPress Trac]

#26600: Search installed themes input has no submit button
----------------------------+----------------------------
 Reporter:  grahamarmfield  |       Owner:  joedolson
     Type:  defect (bug)    |      Status:  reopened
 Priority:  high            |   Milestone:  4.2
Component:  Themes          |     Version:  3.8
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |     Focuses:  accessibility
----------------------------+----------------------------
Changes (by afercia):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 Sorry to reopen this but I'm getting inconsistent results when testing
 this aria-live implementation and I think it would probably need some more
 investigation or a different approach. To my understanding, both changes
 in the DOM '''and''' visibility changes should be announced, see
 http://www.w3.org/TR/wai-aria-implementation/#mapping_events_visibility

 So the current implementation should work, but sometimes the "no themes
 found" message is not read out at all. I can't reproduce consistently
 though.

 Just guessing, but I think the changes order has a role here: what happen
 first? Revealing the "no themes found" message or emptying the themes
 container? (most likely the latter) Which change screen readers should
 announce when there are multiple, consecutive changes inside the same
 element and aria-live is set to "polite"? I really don't know, all I can
 say is it probably needs some more testing. This is probably also the
 result of setting aria-live on a so big region with lots of things
 happening there, as Joe Dolson already pointed out, live regions should be
 as small as possible.

 A different approach could be based on the returned collection count and
 using custom messages as proposed in #31368 if that will be approved,
 hopefully.

 Besides these inconsistencies, there's at least one edge case that can be
 always reproduced:
 - search for a non existent theme, e.g. type "qwerty"
 - the "no themes found" message appears
 - you realize you mistyped the theme name so you search again and
 '''add''' something to the previous search string e.g. now you're
 searching for "qwertyasdfg"
 - in this case, no DOM or visibility changes happen, there's nothing aria-
 live can get

 Additionally, one more "visual" edge case should be fixed in themes.php,
 see screenshot below, to reproduce:
 - search for "qwerty"
 - the "no themes found" message appears
 - clear the search field
 Now both the "no themes found" message '''and''' the installed themes are
 displayed.

 [[Image(https://cldup.com/vRL1E0eT-x.png)]]

--
Ticket URL: <https://core.trac.wordpress.org/ticket/26600#comment:24>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform