[wp-trac] [WordPress Trac] #31373: Revamp Press This

WordPress Trac noreply at wordpress.org
Tue Feb 24 14:53:43 UTC 2015


#31373: Revamp Press This
-----------------------------+-----------------------
 Reporter:  michael-arestad  |       Owner:  azaozz
     Type:  task (blessed)   |      Status:  assigned
 Priority:  normal           |   Milestone:  4.2
Component:  Press This       |     Version:  trunk
 Severity:  normal           |  Resolution:
 Keywords:                   |     Focuses:
-----------------------------+-----------------------

Comment (by stephdau):

 Upgrade notice: the culprit is `!==` and different types between `data.v`
 and `data._version`.
 Using `parseInt()` when comparing them makes the problem go away.

 `wp-admin/js/press-this.php` -> L640 (in 31373.patch):
 {{{
 // Prompt user to upgrade their bookmarklet if there is a version
 mismatch.
 if ( data.v && data._version && parseInt( data.v ) !==  parseInt(
 data._version ) ) {
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31373#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list