[wp-trac] [WordPress Trac] #17376: Multisite Subfolders and bunk /wp-admin areas

WordPress Trac noreply at wordpress.org
Tue Feb 24 05:40:44 UTC 2015


#17376: Multisite Subfolders and bunk /wp-admin areas
-------------------------------------------------+-------------------------
 Reporter:  MadtownLems                          |       Owner:
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  4.2
Component:  Bootstrap/Load                       |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch dev-feedback needs-unit-   |     Focuses:  multisite
  tests                                          |
-------------------------------------------------+-------------------------
Changes (by jeremyfelt):

 * milestone:  Future Release => 4.2


Comment:

 Current status with valid sites at `http://foo.org/` and
 `http://foo.org/bar/`

 With [https://core.trac.wordpress.org/attachment/ticket/17376/17376.5.diff
 17376.5.diff]

 * `http://foo.org/wp-admin/` loads admin of main site.
 * `http://foo.org/bar/wp-admin/` loads admin of bar site.
 * `http://foo.org/typo/wp-admin/` redirects to `http://foo.org/`
 * `http://foo.org/bar/typo/wp-admin/` loads a 404 on bar site.

 With [https://core.trac.wordpress.org/attachment/ticket/17376/17376.4.diff
 17376.4.diff]

 * `http://foo.org/wp-admin/` loads admin of main site.
 * `http://foo.org/bar/wp-admin/` loads admin of bar site.
 * `http://foo.org/typo/wp-admin/` redirects to `http://foo.org/wp-admin/`
 * `http://foo.org/bar/typo/wp-admin/` loads a 404 on bar site.

 I like the simplicity of both patches in that we aren't trying to process
 a lot to figure out where the user is trying to go. I like the behavior of
 17376.5.diff the best as a mistyped `path/wp-admin/` loads a front end
 view. This forces another attempt rather than requiring the reading of an
 admin notice.

 We're probably ok with `http://foo.org/bar/typo/wp-admin/` loading a 404
 instead of redirecting in the case where `/bar/` is a valid path, not that
 WordPress is served from in `/bar/`.

 I'm betting we can find a way to write tests for this in
 `multisite/bootstrap.php`. :)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/17376#comment:24>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list