[wp-trac] [WordPress Trac] #23367: Remove message parameters from admin URl's in the browser address bar

WordPress Trac noreply at wordpress.org
Tue Feb 24 04:12:33 UTC 2015


#23367: Remove message parameters from admin URl's in the browser address bar
-------------------------------------------------+-------------------------
 Reporter:  mark-k                               |       Owner:
     Type:  enhancement                          |  morganestes
 Priority:  low                                  |      Status:  assigned
Component:  Administration                       |   Milestone:  4.2
 Severity:  minor                                |     Version:
 Keywords:  good-first-bug needs-unit-tests      |  Resolution:
  has-patch                                      |     Focuses:
                                                 |  administration
-------------------------------------------------+-------------------------
Changes (by morganestes):

 * keywords:  good-first-bug needs-unit-tests needs-patch => good-first-bug
     needs-unit-tests has-patch


Comment:

 New patch with changes suggested by @markjaquith is attached with a couple
 of things to note:

 * Since canonical links must not be relative, force an absolute URL with
 `get_site_url()` inside `wp_admin_filtered_url()`. Otherwise,
 `remove_query_arg()` returns a relative URL.
 * Use `jQuery.isFunction()` to check for `history.replaceState` support as
 recommended by [https://make.wordpress.org/core/handbook/coding-
 standards/javascript/#type-checks JS coding standards].

--
Ticket URL: <https://core.trac.wordpress.org/ticket/23367#comment:29>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list