[wp-trac] [WordPress Trac] #18132: Misleading message when deleting a user with no sites

[WordPress Trac]

#18132: Misleading message when deleting a user with no sites
-------------------------------------------------+-------------------------
 Reporter:  danielbachhuber                      |       Owner:  Idealien
     Type:  enhancement                          |      Status:  assigned
 Priority:  normal                               |   Milestone:  4.2
Component:  Users                                |     Version:
 Severity:  trivial                              |  Resolution:
 Keywords:  good-first-bug has-patch dev-        |     Focuses:  multisite
  feedback                                       |
-------------------------------------------------+-------------------------

Comment (by DrewAPicture):

 Here's a couple of things  with [attachment:18132_formTable.diff]:

 * Just before the first if/else on the `$users` count, we should probably
 adjust to also checking whether `$users` is empty in addition to not being
 an array. Otherwise, the "not greater than 1" condition could
 theoretically spit out a string for a zero `$users` count there and
 further down
 * `$current_user->ID` in the option value should be escaped with
 `esc_attr()`
 * `!empty( $blogs )` should be `! empty( $blogs )`
 * "User has no sites or content and will be deleted" should end with a
 period
 * The double quotes in the final two strings should instead use `“`
 and `”` respectively

--
Ticket URL: <https://core.trac.wordpress.org/ticket/18132#comment:19>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform