[wp-trac] [WordPress Trac] #18650: Make archives and categories widgets dropdown ada compliant

[WordPress Trac]

#18650: Make archives and categories widgets dropdown ada compliant
------------------------------+----------------------------
 Reporter:  jlevandowski      |       Owner:  joedolson
     Type:  enhancement       |      Status:  reviewing
 Priority:  high              |   Milestone:  4.2
Component:  Widgets           |     Version:  3.2.1
 Severity:  major             |  Resolution:
 Keywords:  has-patch commit  |     Focuses:  accessibility
------------------------------+----------------------------

Comment (by SergeyBiryukov):

 Replying to [comment:22 joedolson]:
 > Attached patch is a refresh of Nacin's patch, but uses .screen-reader-
 text and inserts labels separately from the title content.

 That would result in duplicate widget title and label if the theme doesn't
 support `.screen-reader-text`, see [attachment:18650.6.png].

 The alternative is to turn widget titles into labels, but that might
 result in label styling overriding the header styling, as noted in
 comment:16.

 I've attached two patches which rename some variables for clarity, and
 only add labels if `$title` is not empty, to avoid printing an empty label
 if the title was filtered out by the theme.

 * [attachment:18650.7.patch] turns widget titles into labels.
 * [attachment:18650.8.patch] adds labels separately.

 Which approach are we more comfortable with?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/18650#comment:27>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform