[wp-trac] [WordPress Trac] #30002: ms_not_installed returns 200

[WordPress Trac]

#30002: ms_not_installed returns 200
--------------------------------------+----------------------------
 Reporter:  spacedmonkey              |       Owner:  craig-ralston
     Type:  enhancement               |      Status:  assigned
 Priority:  normal                    |   Milestone:  4.2
Component:  Networks and Sites        |     Version:  4.0
 Severity:  normal                    |  Resolution:
 Keywords:  good-first-bug has-patch  |     Focuses:  multisite
--------------------------------------+----------------------------

Comment (by jeremyfelt):

 I think we should go with calling `dead_db()` instead. It provides the
 ability to show a custom `db-error.php` page and handles the 500 error
 exactly the same as `ms_not_installed()` would otherwise.

 We can also take a cue from `is_blog_installed()` and set a custom
 `$wpdb->error` so that a `db-error.php` template can act accordingly.
 Everything we currently store in `$msg` could be passed this way and
 `ms_not_installed()` can just use `dead_db()`. A more generic message that
 doesn't rely on a DB query can be used when not in `is_admin()`.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30002#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform