[wp-trac] [WordPress Trac] #15015: Customisable submit button for comment form

WordPress Trac noreply at wordpress.org
Fri Feb 20 21:33:51 UTC 2015


#15015: Customisable submit button for comment form
------------------------------------+--------------------
 Reporter:  morpheu5                |       Owner:
     Type:  enhancement             |      Status:  new
 Priority:  normal                  |   Milestone:  4.2
Component:  Comments                |     Version:  3.0.1
 Severity:  normal                  |  Resolution:
 Keywords:  dev-feedback has-patch  |     Focuses:
------------------------------------+--------------------

Comment (by coffee2code):

 Since it's been awhile, I refreshed my [attachment:15015.diff previous
 patch] to apply cleanly against trunk (as of r31484).

 Changes made to accommodate updates in core in the intervening years (that
 caused the previous patch not to apply cleanly any longer):

 * Add 'class' attribute to submit button
 * Treat 'name' attribute as a configurable $arg value

 Improvements made to what I originally proposed:

 * Add docblock for the filter
 * Add $args as argument in call for new filter. Helpful for context and if
 user wants to generate entirely custom markup so they have the requisite
 data rather than having to resort to string parsing or assumptions.
 * Since the `sprintf()` now has so many arguments, I made things multi-
 line for easier reading of the code.

 Attached as [attachment:15015.2.diff].

--
Ticket URL: <https://core.trac.wordpress.org/ticket/15015#comment:26>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list