[wp-trac] [WordPress Trac] #31332: RTL CSS generation: Switch from CSSJanus to RTLCSS

[WordPress Trac]

#31332: RTL CSS generation: Switch from CSSJanus to RTLCSS
--------------------------------------------------+------------------
 Reporter:  ocean90                               |       Owner:
     Type:  defect (bug)                          |      Status:  new
 Priority:  normal                                |   Milestone:  4.2
Component:  Build/Test Tools                      |     Version:
 Severity:  normal                                |  Resolution:
 Keywords:  has-patch dev-feedback needs-testing  |     Focuses:
--------------------------------------------------+------------------

Comment (by jorbin):

 Replying to [comment:3 ocean90]:
 > [attachment:build.diff] is a diff from the CSS files.
 > (Note: The change in `wp-admin/css/ie-rtl.css` is correct and fixes a
 bug in cssjanus.)
 > [[BR]]
 >
 > > Would it possible to get some sample vizrecs for before (w/ CSSJanus)
 and after (w/ RTLCSS)?
 > There isn't much difference, but I just noticed that the shadow of the
 Press This button is now switched in RTL, see
 https://cloudup.com/c6tuCzztRqA.

 That change looks good to me and makes more sense with the pin. The
 pushpin being on the "up" side looks out of place.

 > > The one thing I think I would do differently (and my above patch does
 it) is to keep cssjanus as a command,
 > I don't think this is really necessary. We already have a custom RTL
 task (`grunt rtl`) which should be used.

 Yes, grunt rtl *should* be used, but we don't know if that is what people
 are using (I would guess that most commiters are more likely to use `grunt
 precommit` rather than an individual task), but I also don't see the
 benefit in breaking things when it is so easy for us not to.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31332#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform