[wp-trac] [WordPress Trac] #26600: Search installed themes input has no submit button

[WordPress Trac]

#26600: Search installed themes input has no submit button
------------------------------------+----------------------------
 Reporter:  grahamarmfield          |       Owner:  joedolson
     Type:  defect (bug)            |      Status:  assigned
 Priority:  high                    |   Milestone:  4.2
Component:  Themes                  |     Version:  3.8
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |     Focuses:  accessibility
------------------------------------+----------------------------
Changes (by joedolson):

 * keywords:  needs-patch => has-patch dev-feedback


Comment:

 The attached patch is effective for getting feedback when themes are found
 by a search; but it doesn't handle the case when there are no results.

 Fixing that case is simple in concept, but I found it tricky to actually
 do, the way this is currently set up. What needs to happen is that the no-
 themes response message needs to be added inside the aria-live region when
 a query doesn't return any results. The current set up doesn't work for
 two reasons:

 1) The message isn't inside the aria live region and
 2) The message isn't brought into view when results are not found, but is
 hidden if results *are* found; which means if the aria-live region was
 expanded to .wrap (which I don't recommend; updating regions should be as
 small as possible), it would still not be announced, because it's not
 actually a change to the DOM.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/26600#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform