[wp-trac] [WordPress Trac] #31362: expectedDeprecated() does unexpected things when there's an unexpected deprecated notice

WordPress Trac noreply at wordpress.org
Tue Feb 17 16:11:11 UTC 2015


#31362: expectedDeprecated() does unexpected things when there's an unexpected
deprecated notice
------------------------------+---------------------------
 Reporter:  jdgrimes          |       Owner:  boonebgorges
     Type:  defect (bug)      |      Status:  closed
 Priority:  normal            |   Milestone:  4.2
Component:  Build/Test Tools  |     Version:  3.7
 Severity:  normal            |  Resolution:  fixed
 Keywords:  has-patch         |     Focuses:
------------------------------+---------------------------
Changes (by boonebgorges):

 * status:  reviewing => closed
 * resolution:   => fixed


Comment:

 In [changeset:"31469"]:
 {{{
 #!CommitTicketReference repository="" revision="31469"
 Improved handling of expectedDeprecated and expectedIncorrectUsage
 annotations in unit tests.

 * Do the `expectedDeprecated()` check in `assertPostConditions()` instead
 of `tearDown()`. Previously, `fail`ing inside of `tearDown()` was causing
 the rest of the teardown process to be aborted, resulting in inter-test
 leakage.
 * Collect all `expectedDeprecated` and `expectedIncorrectUsage`
 annotations in an entire method and display them all when `fail`ing,
 instead of showing only the first one.

 Props jdgrimes.
 Fixes #31362.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31362#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list