[wp-trac] [WordPress Trac] #17817: do_action/apply_filters/etc. recursion on same filter kills underlying call

[WordPress Trac]

#17817: do_action/apply_filters/etc. recursion on same filter kills underlying call
-------------------------------------------------+-------------------------
 Reporter:  kernfel                              |       Owner:
     Type:  defect (bug)                         |      Status:  reopened
 Priority:  normal                               |   Milestone:  4.2
Component:  Plugins                              |     Version:  2.2
 Severity:  normal                               |  Resolution:
 Keywords:  dev-feedback has-unit-tests has-     |     Focuses:
  patch 4.2-early needs-docs                     |
-------------------------------------------------+-------------------------

Comment (by jbrinley):

 17817.12.patch attached. It incorporates @wonderboymusic's formatting
 updates (but removes those from lines that would otherwise be untouched).

 There were a few failing unit tests. Some came from #20920. That fix is
 now incorporated into this patch. Some came from #30936, but were really a
 consequence of #28535. Hook objects were backed up by reference, so new
 hooks added weren't removed. This updates `WP_UnitTestCase` to use clone
 when backing up and restoring `$wp_filter`.

 Patch should now apply cleanly and all unit tests should pass.

 Thanks for the feedback, @wonderboymusic and @DrewAPicture.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/17817#comment:105>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform