[wp-trac] [WordPress Trac] #17817: do_action/apply_filters/etc. recursion on same filter kills underlying call

WordPress Trac noreply at wordpress.org
Mon Feb 16 23:37:41 UTC 2015


#17817: do_action/apply_filters/etc. recursion on same filter kills underlying call
-------------------------------------------------+-------------------------
 Reporter:  kernfel                              |       Owner:
     Type:  defect (bug)                         |      Status:  reopened
 Priority:  normal                               |   Milestone:  4.2
Component:  Plugins                              |     Version:  2.2
 Severity:  normal                               |  Resolution:
 Keywords:  dev-feedback has-unit-tests has-     |     Focuses:
  patch 4.2-early needs-docs                     |
-------------------------------------------------+-------------------------
Changes (by DrewAPicture):

 * keywords:  dev-feedback has-unit-tests has-patch 4.2-early => dev-
     feedback has-unit-tests has-patch 4.2-early needs-docs


Comment:

 Some notes:

 1. Worth making a decision about how/if we plan to support making this
 extensible, i.e. marking as `final` or not

 2. Decide if there's merit in ''not'' introducing methods that directly
 mirror their legacy counterparts, e.g. new methods that take four
 parameters right out of the gate.

 3. We need to do a full inline-docs pass on this before the initial commit
 (if it happens).

   * Some missing parameter and return descriptions
   * Missing `@since` tags
   * Missing `@access` tags
   * Inline documentation in these new methods explaining what's going on

 4. I enjoy a good whitespace refactoring as much as the next developer,
 but I'd like to see a cleaner a patch with fewer vanilla whitespacing
 changes.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/17817#comment:102>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list