[wp-trac] [WordPress Trac] #30478: Comment query results returned in an inconsistent order on some versions of MySQL

[WordPress Trac]

#30478: Comment query results returned in an inconsistent order on some versions of
MySQL
--------------------------+---------------------------
 Reporter:  boonebgorges  |       Owner:  boonebgorges
     Type:  defect (bug)  |      Status:  closed
 Priority:  normal        |   Milestone:  4.2
Component:  Comments      |     Version:
 Severity:  normal        |  Resolution:  fixed
 Keywords:  has-patch     |     Focuses:
--------------------------+---------------------------
Changes (by boonebgorges):

 * owner:   => boonebgorges
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"31467"]:
 {{{
 #!CommitTicketReference repository="" revision="31467"
 Improve 'orderby' syntax for `WP_Comment_Query`.

 Since [29027], `WP_Query` has supported an array of values for the
 `$orderby`
 parameter, with field names as array keys and ASC/DESC as the array
 values.
 This changeset introduces the same syntax to `WP_Comment_Query`.

 We leverage the new support for multiple ORDER BY clauses to fix a bug
 that
 causes comments to be queried in an indeterminate order when sorting by
 the
 default `comment_date_gmt` and comments share the same value for
 `comment_date_gmt`. By always including a `comment_ID` subclause at the
 end of
 the ORDER BY statement, we ensure that comments always have a unique
 fallback
 for sorting.

 This changeset also includes improvements paralleling those introduced to
 `WP_Query` in [31312] and [31340], which allow `$orderby` to accept array
 keys
 from specific `$meta_query` clauses. This change lets devs sort by
 multiple
 clauses of an associated meta query. See #31045.

 Fixes #30478. See #31265.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30478#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform