[wp-trac] [WordPress Trac] #18132: Misleading message when deleting a user with no sites
WordPress Trac
noreply at wordpress.org
Sat Feb 14 01:37:37 UTC 2015
#18132: Misleading message when deleting a user with no sites
----------------------------------------+-----------------------------
Reporter: danielbachhuber | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: Future Release
Component: Users | Version:
Severity: trivial | Resolution:
Keywords: good-first-bug needs-patch | Focuses: multisite
----------------------------------------+-----------------------------
Changes (by SergeyBiryukov):
* keywords: good-first-bug has-patch => good-first-bug needs-patch
Comment:
A couple of issues with [attachment:18132_refreshed.diff]:
* We can't have 'user' and 'following users' as separate strings injected
into other strings. Some languages require the whole string to be
translated differently in each case.
* `_n()` is not actually an ideal solution here. In some languages, the
first form ("the user") can be used for 21, 31, etc., but it doesn't
necessarily mean it's a singular form (it needs to be translated
differently when dealing with 1 user vs. 21 users). See
comment:5:ticket:28502.
We should just check if `count( $users ) > 1` and display separate strings
for each case.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/18132#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list