[wp-trac] [WordPress Trac] #27399: Filter the HTML output of wp_get_attachment_image

WordPress Trac noreply at wordpress.org
Wed Feb 11 17:19:45 UTC 2015


#27399: Filter the HTML output of wp_get_attachment_image
-----------------------------+------------------------------
 Reporter:  fgirardey        |       Owner:
     Type:  enhancement      |      Status:  new
 Priority:  normal           |   Milestone:  Awaiting Review
Component:  Media            |     Version:  3.8.1
 Severity:  normal           |  Resolution:
 Keywords:  has-patch close  |     Focuses:
-----------------------------+------------------------------
Changes (by DrewAPicture):

 * keywords:  has-patch => has-patch close


Comment:

 I'm not really a fan of introducing a filter on built-HTML content like
 this. We talk a lot about the usefulness (or lack thereof) of filtering
 built SQL statements in much the same light. The stated use-case comment:2
 can already be accomplished with the `wp_get_attachment_image_attributes`
 filter.

 I don't think the existence of a similarly-intentioned filter in another
 function is enough of a justification for the added complexity in this
 context.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/27399#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list