[wp-trac] [WordPress Trac] #31202: Customizer preview iframe should have a title

WordPress Trac noreply at wordpress.org
Wed Feb 11 13:48:25 UTC 2015


#31202: Customizer preview iframe should have a title
------------------------------+----------------------------
 Reporter:  celloexpressions  |       Owner:  ocean90
     Type:  defect (bug)      |      Status:  reviewing
 Priority:  normal            |   Milestone:  4.2
Component:  Customize         |     Version:  3.4
 Severity:  normal            |  Resolution:
 Keywords:  needs-patch       |     Focuses:  accessibility
------------------------------+----------------------------

Comment (by afercia):

 New patch tries to add a title attribute for:
 - main iframe (used just when the customizer overlays an admin page)
 - preview iframe
 - login iframe (shown ''in lieu'' of the preview iframe after session
 expiration)

 Please check carefully, I'm not sure about a couple of things, one of them
 is:
 {{{
 iframe = $('<iframe src="' + self.previewUrl() + '" title="' +
 wp.customize.l10n.previewIframeTitle + '" />').hide();
 }}}
 why this way to select an already existing iframe? or maybe there are edge
 case conditions when the iframe needs to be created and suddenly hidden?
 Definitely don't have a deep knowledge of all the customizer code, but I'm
 a bit confused about that piece of code.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31202#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list