[wp-trac] [WordPress Trac] #30827: wp_can_install_language_pack(): Direct access to $upgrader->fs_connect() can produce undefined index notices

[WordPress Trac]

#30827: wp_can_install_language_pack(): Direct access to $upgrader->fs_connect()
can produce undefined index notices
-----------------------------------+-----------------------------
 Reporter:  ocean90                |       Owner:  SergeyBiryukov
     Type:  defect (bug)           |      Status:  reopened
 Priority:  low                    |   Milestone:  4.1.1
Component:  Filesystem API         |     Version:  4.0
 Severity:  minor                  |  Resolution:
 Keywords:  has-patch fixed-major  |     Focuses:
-----------------------------------+-----------------------------

Comment (by dd32):

 I'm so-so on including this in 4.1.1, I could go either way, unless
 someone feels strongly, lets close it on 4.2.

 Realistically, it's only a PHP notice, and none of the strings missing
 should be needed during a translation install, it's also unlikely any
 other alterations will be made to this file in 4.1.1 (meaning one less
 file in a 4.1 -> 4.1.1 update).

 Worst case, as @ocean90 hit here, the upgrade can't find the wp-content
 directory and it emits a PHP notice + `fs_no_content_dir` instead of a
 human-readable message.. a case that should be exceedingly rare.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30827#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform