[wp-trac] [WordPress Trac] #31180: Add tumblr.com oEmbed support
WordPress Trac
noreply at wordpress.org
Mon Feb 9 03:14:38 UTC 2015
#31180: Add tumblr.com oEmbed support
----------------------------+------------------------------
Reporter: elliottcarlson | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Embeds | Version:
Severity: normal | Resolution:
Keywords: | Focuses:
----------------------------+------------------------------
Comment (by nacin):
Hi Elliott, thanks for stopping by! Sounds good to us. We'll want to due
some due diligence on this endpoint and make sure it always returns what
we expect, such as when maxwidth and maxheight are all sorts of values (in
particular, we set a super tall maxheight in WP), proper handling when
they are not integers, etc.
I'm having trouble tracking down an announcement post or developer
documentation for this endpoint. Could you share?
For reference, here's the guidelines we usually use when adding oEmbed
endpoints: https://make.wordpress.org/core/handbook/design-decisions
/#whitelisting-oembed-providers. Obviously, adding Tumblr is a given, and
you don't need to go through that checklist to justify it. For established
services, the only bullet point I ever worry about is:
> Is its oEmbed endpoint clearly established and properly documented?
Sometimes, they are just a developer’s pet project that may not be
supported.)
--
Ticket URL: <https://core.trac.wordpress.org/ticket/31180#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list