[wp-trac] [WordPress Trac] #31196: Loading indicators for the Customizer preview

WordPress Trac noreply at wordpress.org
Tue Feb 3 11:24:55 UTC 2015


#31196: Loading indicators for the Customizer preview
------------------------------+-----------------------------
 Reporter:  celloexpressions  |       Owner:
     Type:  enhancement       |      Status:  new
 Priority:  normal            |   Milestone:  Future Release
Component:  Customize         |     Version:  3.4
 Severity:  normal            |  Resolution:
 Keywords:  has-patch         |     Focuses:  ui, javascript
------------------------------+-----------------------------

Comment (by westonruter):

 Replying to [comment:6 Fab1en]:
 > I added the loading spinner when a control with refresh transport is
 triggering a preview reload in [attachment:31196.3.patch]. I also renamed
 the `unload` event to `loading`.
 >
 > One thing is still missing : "Loading" message translation. Is it OK to
 introduce a new JS l10n global var to handle this in `customize-
 preview.js` ?

 It's ok, but why not add it to the
 `WP_Customize_Manager::customize_preview_settings()` method like so?
 https://github.com/xwp/wordpress-develop/pull/61/files#diff-
 4fb8a477f559bdfad2c1e6db6d1c8b06R832

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31196#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list