[wp-trac] [WordPress Trac] #31203: Focus style for add-new-theme should match hover style
WordPress Trac
noreply at wordpress.org
Mon Feb 2 16:08:47 UTC 2015
#31203: Focus style for add-new-theme should match hover style
------------------------------+----------------------------
Reporter: celloexpressions | Owner:
Type: defect (bug) | Status: reopened
Priority: normal | Milestone: 4.2
Component: Themes | Version: 3.8
Severity: normal | Resolution:
Keywords: has-patch | Focuses: accessibility
------------------------------+----------------------------
Comment (by celloexpressions):
Replying to [comment:3 iseulde]:
> Do you really need the `calc` stuff there? I just remember making a
patch for this, so might be worth looking at that other ticket. Not every
single problem in that other ticket needs to be solved to commit a patch.
I see nothing wrong with `calc`, and it will still be functional, just a
bit shorter on IE8, but that's just there to preserve the spacing because
all of the styling was based on the div having hover/focus instead of the
`a`. The other option would be to restructure the html or re-do the CSS
further, but I'm much in favor of a simpler fix.
Sidenote: I generally prefer more targeted tickets like this because that
also avoids issues where the fact that similar fixes may exist as part of
patches elsewhere isn't searchable or easy to remember seeing.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/31203#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list