[wp-trac] [WordPress Trac] #31130: WP_INSTALLING causes leakage between unit tests

[WordPress Trac]

#31130: WP_INSTALLING causes leakage between unit tests
------------------------------+-----------------------------
 Reporter:  boonebgorges      |       Owner:
     Type:  defect (bug)      |      Status:  new
 Priority:  normal            |   Milestone:  Future Release
Component:  Build/Test Tools  |     Version:
 Severity:  normal            |  Resolution:
 Keywords:                    |     Focuses:
------------------------------+-----------------------------
Changes (by jeremyfelt):

 * milestone:  Awaiting Review => Future Release


Comment:

 I think some flavor of option 2 is the sane way forward. I did some
 exploration of this with `DOMAIN_CURRENT_SITE` and `PATH_CURRENT_SITE`
 during the 4.0 cycle in
 [https://core.trac.wordpress.org/attachment/ticket/27884/27884.diff
 27884.diff], but backed off quite a bit. There are a handful of constants
 that would be nice to flip on and off or back and forth without having to
 fire up an entirely new process. `WP_INSTALLING` is a pretty brutal one,
 so we'll need to take care.

 Option 3 would be the next best bet if it worked. Trying to get the
 multisite tests to actually run in a separate process was not an enjoyable
 time as the separate processes would use the default config and the
 multisite tables would not be available. I'm sure there is a way to do
 this, I just [https://core.trac.wordpress.org/ticket/30256#comment:4
 couldn't find it].

 Option 4 would work, but would always be a source of possible error when
 committing new tests.

 Related #27884, #30256

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31130#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform