[wp-trac] [WordPress Trac] #28478: remove open sans font as a dependency

[WordPress Trac]

#28478: remove open sans font as a dependency
-------------------------------------------------+-------------------------
 Reporter:  norcross                             |       Owner:
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  4.2
Component:  Script Loader                        |     Version:  3.8
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch dev-feedback 2nd-opinion   |     Focuses:  ui,
  needs-testing                                  |  administration
-------------------------------------------------+-------------------------

Comment (by dd32):

 Being an external dependancy is another argument entirely (which was done
 to death when we added it), but it's still a dependancy and registering it
 as such seems like the correct way to go to me (ie. as we currently do
 it).

 [attachment:28478.2.diff] shows that this IS a dependancy, simply based on
 the locations that it then needs to be added in.

 I'm personally behind the argument that re-registering it with a empty url
 should be the correct way of disabling it.
 There's two ways to do that:
 - deregister/register it as false
 - register it as false before core does, {{{ add_action(
 'wp_default_styles', function( &$styles ) { $styles->add( 'open-sans',
 false ); }, 9 ); }}} should probably do it (untested)

 If the register method is too hard, which realistically I don't think it
 is for altering a major part of the admin styling, then introducing an
 explicit filter seems like the better way (although you can already use
 the `gettext` filter, it's way too heavy-handed for this)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/28478#comment:16>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform