[wp-trac] [WordPress Trac] #34879: Typo in wp_title separator placeholder

[WordPress Trac]

#34879: Typo in wp_title separator placeholder
-------------------------------------------------+-------------------------
 Reporter:  morganestes                          |       Owner:
     Type:  defect (bug)                         |  morganestes
 Priority:  lowest                               |      Status:  assigned
Component:  General                              |   Milestone:  4.5
 Severity:  trivial                              |     Version:  1.0
 Keywords:  good-first-bug has-patch needs-      |  Resolution:
  unit-tests                                     |     Focuses:  template
-------------------------------------------------+-------------------------

Comment (by dossy):

 The `$t_sep` value shouldn't really be testable since it's an internal
 implementation detail of the function, not meant to be exposed to any
 caller.  However, if you really want tests that fail given the current
 typo, I can write one - although, it'll be very tightly coupled to the
 specific implementation of `wp_title()` and not really be testing the
 higher-level functionality (e.g., if `wp_title()` is refactored, the test
 will fail but the function could still likely be doing the right thing in
 general).

 Really, shouldn't `wp_title()`'s implementation get rewritten to use the
 new `wp_get_document_title()` in 4.4?

 Anyway, I've uploaded [attachment:34879-2.patch 34879-2.patch] which adds
 a test that will fail without the "fix" if that helps.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34879#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform