[wp-trac] [WordPress Trac] #35274: Break-out conditional in allow_subdomain_install()

[WordPress Trac]

#35274: Break-out conditional in allow_subdomain_install()
--------------------------------------+------------------------------
 Reporter:  stevegrunwell             |       Owner:
     Type:  enhancement               |      Status:  new
 Priority:  normal                    |   Milestone:  Awaiting Review
Component:  Networks and Sites        |     Version:  trunk
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:  multisite
--------------------------------------+------------------------------

Comment (by nacin):

 We have never used `filter_var()` in core. Filter is enabled by default,
 but it can be disabled. I would estimate that this would be a minuscule
 number of sites, but even 0.1% is still tens of thousands of sites that
 would see a fatal error unexpectedly. Granted, very few would be trying to
 create a network, but I'd expect at least one bug report citing it upon
 release.

 While someone is unlikely to deliberately disable ext/filter, it's
 actually not terribly uncommon to use the flag `--disable-all` and then
 add back what you need -- and sometimes an important one is missed.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35274#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform