[wp-trac] [WordPress Trac] #20302: Allow comment_form() to add attributes to <form> tag

WordPress Trac noreply at wordpress.org
Wed Dec 30 21:28:13 UTC 2015


#20302: Allow comment_form() to add attributes to <form> tag
-------------------------+------------------------------
 Reporter:  psbook       |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  Awaiting Review
Component:  Comments     |     Version:  3.3.1
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |     Focuses:
-------------------------+------------------------------

Comment (by swissspidy):

 I like the approach of the new patch. Some notes:

 * The closure inside `test_extra_comment_form_attributes` needs to go into
 a new method. Closures aren't supported in PHP 5.2.
 * The new `attributes` argument needs to be documented in the DocBlock for
 `comment_form()`
 * `attributes` sounds misleading. What are these attributes for? Since
 there's `class_form` and `id_form` already, `attributes_form` is probably
 better

--
Ticket URL: <https://core.trac.wordpress.org/ticket/20302#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list